Add simple composer 2 blueprint #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
reviewed
Sep 20, 2022
There was a problem hiding this comment.
I know nothing about composer so bear with me:
- I see that you call this
composer-2, can you explain somewhere how it differs from version 1? - Does v2 supersede v1? If the answer is no, then perhaps we should use a different name
- Based on some of the variable names it seems like you intend to use this from FAST. Is that the case?
|
wiktorn
reviewed
Sep 27, 2022
juliocc
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add simple composer 2 blueprint.
It implements:
It supports: