Network dashboard: Subnet IP utilization update #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
approved these changes
Sep 26, 2022
|
@aurelienlegrand Pls rebase this with the latest master (Be careful this will move the whole stuff to the new blueprints folder) |
gleichda
suggested changes
Sep 28, 2022
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/metrics.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/subnets.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/subnets.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/subnets.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/subnets.py
Outdated
Show resolved
Hide resolved
gleichda
reviewed
Sep 28, 2022
blueprints/cloud-operations/network-dashboard/cloud-function/main.py
Outdated
Show resolved
Hide resolved
gleichda
reviewed
Sep 28, 2022
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/subnets.py
Outdated
Show resolved
Hide resolved
gleichda
reviewed
Sep 28, 2022
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/subnets.py
Outdated
Show resolved
Hide resolved
gleichda
approved these changes
Sep 29, 2022
|
Thanks again @gleichda for your great, in depth review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a metric for subnet IP utilization, for example 0.7 means 70% of the IP addresses in the subnet are currently used.
Adding support for monitoring folders (MONITORED_FOLDERS_LIST environment variable). The cloud function will monitor all projects under the provided folders (this is recursive so it applies even to sub folders).