Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New PSC hybrid blueprint #879

Merged
merged 10 commits into from
Oct 16, 2022
Merged

New PSC hybrid blueprint #879

merged 10 commits into from
Oct 16, 2022

Conversation

LucaPrete
Copy link
Member

No description provided.

@LucaPrete LucaPrete requested review from ludoo and sruffilli October 13, 2022 15:22
@LucaPrete LucaPrete self-assigned this Oct 13, 2022
@sruffilli
Copy link
Collaborator

Can you update the blueprints/networking/README.md file too?

sruffilli
sruffilli reviewed Oct 14, 2022
View reviewed changes
blueprints/networking/psc-hybrid/README.md Outdated Show resolved Hide resolved
blueprints/networking/psc-hybrid/README.md Outdated Show resolved Hide resolved
blueprints/networking/psc-hybrid/main.tf Show resolved Hide resolved
blueprints/networking/psc-hybrid/main.tf Outdated Show resolved Hide resolved
ludoo
ludoo requested changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice lean example, dropped a couple minor comments

be aware that I'm in the process of moving the net-vpc module to tf 1.3 ;)

blueprints/networking/psc-hybrid/main.tf Outdated Show resolved Hide resolved
blueprints/networking/psc-hybrid/main.tf Show resolved Hide resolved
blueprints/networking/psc-hybrid/main.tf Outdated Show resolved Hide resolved
@LucaPrete LucaPrete requested review from ludoo and sruffilli October 14, 2022 08:03
ludoo
ludoo requested changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz address all outstanding comments

@LucaPrete LucaPrete requested a review from ludoo October 14, 2022 14:32
@LucaPrete LucaPrete merged commit a8ddf5d into master Oct 16, 2022
@LucaPrete LucaPrete deleted the hybrid-poc-blueprint branch October 16, 2022 08:18
@ludoo ludoo changed the title Add PSC hybrid blueprint New PSC hybrid blueprint Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@sruffilli sruffilli Awaiting requested review from sruffilli

Assignees

@LucaPrete LucaPrete

Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucaPrete @sruffilli @ludoo