Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project-factory: allow folder_id to be defined in defaults_file #897

Conversation

Malet
Copy link
Contributor

@Malet Malet commented Oct 19, 2022

Currently, setting the folder_id in defaults.yaml but not in the project.yaml, results in:

╷
│ Error: Unsupported attribute
│ 
│   on main.tf line 44, in module "projects":
│   44:   folder_id              = each.value.folder_id
│     ├────────────────
│     │ each.value is object with 1 attribute "labels"
│ 
│ This object does not have an attribute named "folder_id".
╵

This change allows you to set the folder_id in the defaults.yaml and have it be used for all the projects selected by the glob pattern.

@Malet Malet force-pushed the feature/project-factory-default-folder-id branch from 6fe5ab5 to fe6fd3d Compare October 20, 2022 14:52
@ludoo ludoo changed the title feat(project-factory): allow folder_id to be defined in defaults_file Project-factory: allow folder_id to be defined in defaults_file Oct 20, 2022
@juliocc juliocc merged commit 66b2e2f into GoogleCloudPlatform:master Oct 21, 2022
@juliocc
Copy link
Collaborator

juliocc commented Oct 21, 2022

Thanks @Malet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants