Static routes monitoring metrics added to network dashboard BP #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-foundation-fabric into maunope/static_routes
|
Could you please add a description and/or a descriptive title? |
maunope
changed the title
aurelienlegrand
requested changes
Oct 21, 2022
There was a problem hiding this comment.
Thanks Maurizio for another contribution.
Just to clarify, we have different limits:
- static routes per VPC peering group
- static routes per project (regional + global if global routing mode)
You are implementing both, right? (the global part is fine for now, the regional part can come later)
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/routes.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/routes.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/routes.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/routes.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/routes.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/routes.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/routes.py
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/routes.py
Outdated
Show resolved
Hide resolved
Both, for global only. added an assumption in readme.md explaining it only works with global for now, and with peering routes always exchanged |
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/routes.py
Outdated
Show resolved
Hide resolved
…oud-foundation-fabric into maunope/static_routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added static routes metrics, for single VPC and for PPG, a few other minor refactorings