fix: use kebab case for config file consistently #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying keys in the configuration file, one must use kebab case. This commit ensures the instance connection names also use kebab case and updates the README to accurately describe the feature. When configuring the Proxy with a config file, one must use matching flag names and specify any instances with the special key instance-connection-name, or instance-connection-name-i, where i is the zero-based index of the instance.
jackwotherspoon
approved these changes
Feb 26, 2024
Co-authored-by: Jack Wotherspoon <[email protected]>
|
FYI @marklonquist |
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Mar 26, 2024
This is a port of two commits: - GoogleCloudPlatform/cloud-sql-proxy#2106 - GoogleCloudPlatform/cloud-sql-proxy#2130
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Mar 26, 2024
This is a port of two commits: - GoogleCloudPlatform/cloud-sql-proxy#2106 - GoogleCloudPlatform/cloud-sql-proxy#2130
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Mar 28, 2024
This is a port of two commits: - GoogleCloudPlatform/cloud-sql-proxy#2106 - GoogleCloudPlatform/cloud-sql-proxy#2130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying keys in the configuration file, one must use kebab case. This commit ensures the instance connection names also use kebab case and updates the README to accurately describe the feature.
When configuring the Proxy with a config file, one must use matching flag names and specify any instances with the special key instance-connection-name, or instance-connection-name-i, where i is the zero-based index of the instance.
Follow-on to #2106