Make Partition into dedicated dataclass #3563
Open
+89
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbas1902
reviewed
Jan 24, 2025
| return len(self.nodesets_tpu) > 0 | ||
|
|
||
| @property | ||
| def any_dynamic(self) -> bool: |
There was a problem hiding this comment.
Nit: I'd probably name it something like has_dynamic
abbas1902
reviewed
Jan 24, 2025
| @@ -180,7 +177,7 @@ def nodeset_dyn_lines(nodeset): | |||
| ) | |||
|
|
|||
|
|
|||
| def partitionlines(partition, lkp: util.Lookup) -> str: | |||
| def partitionlines(partition: Partition, lkp: util.Lookup) -> str: | |||
There was a problem hiding this comment.
Nit: Could we change this to partition_lines?
abbas1902
reviewed
Jan 24, 2025
| @@ -74,11 +74,11 @@ def test_group_nodes_bulk(mock_create_placements, mock_tpu): | |||
| "t": TstNodeset(nodeset_name="t"), | |||
| }, | |||
| partitions={ | |||
| "p1": TstPartition( | |||
| "p1": dict( | |||
There was a problem hiding this comment.
Why not use the Partition class?
abbas1902
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partition_feature.