Added support for clean target to remove gcluster binary and the ghpc… #3577
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added label |
mr0re1
reviewed
Jan 22, 2025
Makefile
Outdated
| @@ -72,6 +73,25 @@ install-dev-deps: warn-terraform-version warn-packer-version check-pre-commit ch | |||
| pip install -r community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/requirements.txt | |||
| pip install -r community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/tests/requirements.txt | |||
|
|
|||
| clean: | |||
| @echo "PATH: $$PATH" | |||
| @for binary_target in $(BINARY_TARGETS); do \ | |||
There was a problem hiding this comment.
AFAIK it will not remove binaries installed into /usr/local/bin and ~/bin. PTAL at install target
There was a problem hiding this comment.
Thank you for the feedback. I've updated the PR to remove the build targets from:
- current dir
- ~/bin
- /usr/local/bin
There was a problem hiding this comment.
Hi, I'm not seeing the updated version, perhaps its stuck in your local branch?
nadig-google
added
the
release-improvements
nadig-google
force-pushed
the
update_makefile
branch
from
371a91c to
b365ff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL updates the Makefile to add a "clean" make target. Running "make clean" will remove the regular file "gcluster" and the symlink "ghpc" (links to gcluster).
This PR to removes the build targets from the following directories after checking if the files exist and if it has permissions to delete them:
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.