Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing indexes and a3U documentation in readme for gke blueprints #3599

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

parulbajaj01
Copy link
Contributor

Updated Readme file with the following changes:

  1. Added missing entry in index for gke-managed-hyperdisk.yaml & gke-managed-parallelstore.yaml blueprints
  2. Added documentation for gke-a3-ultragpu.yaml

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Jan 28, 2025
Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were these changes tested?

@parulbajaj01
Copy link
Contributor Author

Rendered the markup on GitHub itself and the changes look good.

Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parulbajaj01 parulbajaj01 merged commit 1a73e1d into GoogleCloudPlatform:develop Feb 4, 2025
10 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants