Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance deploy to output JSON instead of plain-english #3618

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

nadig-google
Copy link

@nadig-google nadig-google commented Jan 31, 2025

NOTE NOTE NOTE
This a draft Pull Request to solicit early feedback. It has not been tested. This is also not the final implementation.
NOTE NOTE NOTE

This pull request adds support to output JSON instead of the usual "english text output" to "gcluster deploy". It adds a new flag to the deploy command called --json-output which writes a file called cluster_toolkit_output.json with the output messages written JSON format (instead of the usual "english text output" to STDOUT.

This pull request was submitted git commit --no-verify because of failing go staticchecks that prevent git commit from successfully running

What works as of now

  • Writes output to JSON file
  • Writes unique file per Terraform group to avoid files being overwritten

What does not work as of now:

@nadig-google nadig-google added enhancement New feature or request go Pull requests that update Go code labels Jan 31, 2025
cmd/utils.go Outdated Show resolved Hide resolved
pkg/shell/terraform.go Outdated Show resolved Hide resolved
cmd/utils.go Outdated Show resolved Hide resolved
pkg/shell/terraform.go Outdated Show resolved Hide resolved
pkg/shell/terraform.go Outdated Show resolved Hide resolved
pkg/shell/terraform.go Outdated Show resolved Hide resolved
@mr0re1 mr0re1 assigned nadig-google and unassigned mr0re1 Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants