Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes HPL benchmark test due to WARMUP_END_PROG environment variable. #3631

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

samskillman
Copy link
Collaborator

Previously if you don't pass WARMUP_END_PROG, this will block after the warmup because OpenMPI doesn't pass environment variables by default.

Also brings up to date with gke-a3-ultragpu best practices with GKE cluster versions. Has been tested manually.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

Also brings up to date with gke-a3-ultragpu
@samskillman samskillman added the release-bugfix Added to release notes under the "Bug fixes" heading. label Feb 1, 2025
@samskillman samskillman merged commit d32184d into develop Feb 1, 2025
14 of 60 checks passed
@samskillman samskillman deleted the fix/gke-hpl-test branch February 1, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants