Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guest accelerator (broken for GKE) #3656

Conversation

annuay-google
Copy link
Contributor

Fixes breaking change introduced in #3448
Guest accelerator config for GKE node pool differs from that of Compute Instance

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@annuay-google annuay-google changed the base branch from main to develop February 10, 2025 08:50
@annuay-google annuay-google added the release-bugfix Added to release notes under the "Bug fixes" heading. label Feb 10, 2025
@SwarnaBharathiMantena
Copy link
Contributor

LGTM

@annuay-google annuay-google merged commit 0107923 into GoogleCloudPlatform:develop Feb 10, 2025
13 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants