Add controller save state disk #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssa-sm
added
the
release-key-new-features
mr0re1
reviewed
Feb 11, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 11, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 11, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Show resolved
Hide resolved
mr0re1
reviewed
Feb 11, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 11, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 11, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/variables.tf
Outdated
Show resolved
Hide resolved
alyssa-sm
force-pushed
the
disk-save-state
branch
5 times, most recently
from
362adae to
7e8e622
Compare
mr0re1
reviewed
Feb 14, 2025
community/modules/internal/slurm-gcp/instance_template/variables.tf
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 14, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 14, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/variables.tf
Show resolved
Hide resolved
mr0re1
reviewed
Feb 14, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 14, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 14, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Show resolved
Hide resolved
mr0re1
reviewed
Feb 14, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Outdated
Show resolved
Hide resolved
alyssa-sm
force-pushed
the
disk-save-state
branch
from
2e6fb84 to
13537b5
Compare
mr0re1
reviewed
Feb 19, 2025
community/modules/internal/slurm-gcp/internal_instance_template/main.tf
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 19, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 19, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/variables.tf
Show resolved
Hide resolved
mr0re1
reviewed
Feb 19, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/slurm_files.tf
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 19, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/variables.tf
Outdated
Show resolved
Hide resolved
alyssa-sm
force-pushed
the
disk-save-state
branch
from
13537b5 to
7ddae51
Compare
mr0re1
approved these changes
Feb 20, 2025
mr0re1
reviewed
Feb 20, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf
Show resolved
Hide resolved
alyssa-sm
force-pushed
the
disk-save-state
branch
from
7ddae51 to
bdfb98e
Compare
alyssa-sm
requested review from
chengcongdu,
douglasjacobsen,
samskillman,
yuryu and
a team
as code owners
alyssa-sm
force-pushed
the
disk-save-state
branch
from
bdfb98e to
1f0be9f
Compare
Revert "Remove unused MD5s from config"
alyssa-sm
force-pushed
the
disk-save-state
branch
from
1f0be9f to
bc8c36f
Compare
alyssa-sm
merged commit d4b5e9b
into
GoogleCloudPlatform:develop
11 of 58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a state save disk for the controller. With this implementation, slurm information saved on the controller will persist even if the controller were to be destroyed.