Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Update io_bazel_rules_go to fix a build issue. #13

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

rkolchmeyer
Copy link
Contributor

@rkolchmeyer rkolchmeyer commented Jul 11, 2019

Building cos-customizer results in the following error:

Incompatible flag --incompatible_require_ctx_in_configure_features has been flipped, and the mandatory parameter 'ctx' of cc_common.configure_features is missing. Please add 'ctx' as a named parameter. See bazelbuild/bazel#7793 for details.

A new release of Bazel made a backwards incompatible change that breaks compatibility with old Go build rules. Updating our Go build rules to the latest version fixes this problem.

@rkolchmeyer rkolchmeyer requested a review from xueweiz July 11, 2019 18:23
@xueweiz
Copy link

xueweiz commented Jul 11, 2019

Could you also briefly explain the build issue on the PR description? i.e. maybe paste some error messages? Thanks!

@xueweiz xueweiz merged commit 50054e2 into GoogleCloudPlatform:master Jul 11, 2019
@rkolchmeyer
Copy link
Contributor Author

Sure. The specific error is the following:

Incompatible flag --incompatible_require_ctx_in_configure_features has been flipped, and the mandatory parameter 'ctx' of cc_common.configure_features is missing. Please add 'ctx' as a named parameter. See bazelbuild/bazel#7793 for details.

A new release of Bazel made a backwards incompatible change that breaks compatibility with old Go build rules. Updating our Go build rules to the latest version fixes this problem.

@rkolchmeyer rkolchmeyer deleted the build branch July 11, 2019 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants