Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): Azure user permission fix #476

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Conversation

shane-borden
Copy link
Collaborator

No description provided.

@shane-borden shane-borden requested a review from cofin January 15, 2025 23:33
@shane-borden shane-borden marked this pull request as draft January 16, 2025 13:46
@shane-borden shane-borden marked this pull request as ready for review January 16, 2025 14:00
@cofin cofin changed the title Mssql azure user permission fix fix(mssql): Azure user permission fix Jan 16, 2025
Copy link
Collaborator

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofin cofin merged commit a40e1f2 into main Jan 16, 2025
15 checks passed
@cofin cofin deleted the mssql-azure-user-permission-fix branch January 16, 2025 16:30
trivikram29 pushed a commit to trivikram29/database-assessment-1 that referenced this pull request Feb 4, 2025
* Fix: Update user logic for Azure SQL DB

* Fix: Syntax error for SUBSTRING directive

* fix: missing input variable for AZURE SQL Database

* Update scripts/collector/sqlserver/createUserWithSQLAuth.ps1

Co-authored-by: Cody Fincher <[email protected]>
Signed-off-by: Shane Borden <[email protected]>

---------

Signed-off-by: Shane Borden <[email protected]>
Co-authored-by: Shane Borden <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants