Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: set gcloud project once in config #418

Merged

Conversation

scotthart
Copy link
Collaborator

fixes #268

@scotthart scotthart requested a review from a team as a code owner October 24, 2024 17:46
@scotthart scotthart force-pushed the readme_update_project branch from 0881d5d to 27894ba Compare November 4, 2024 20:13
@scotthart scotthart enabled auto-merge (squash) November 4, 2024 21:43
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (700640a) to head (27894ba).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   89.40%   85.89%   -3.52%     
==========================================
  Files          97       96       -1     
  Lines        3133     2814     -319     
  Branches        0      203     +203     
==========================================
- Hits         2801     2417     -384     
+ Misses        332      282      -50     
- Partials        0      115     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gcloud config set project ${GOOGLE_CLOUD_PROJECT}
```


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superduper nit: double space

@scotthart scotthart merged commit ded5e89 into GoogleCloudPlatform:main Nov 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup README files to use implicit gcloud project settings
3 participants