Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterizing min_epochs, max_epochs & max_steps #107

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

Yash9060
Copy link
Collaborator

Internal issues: b/366046586
One of the comment on #106 was to parameterize min_epochs/max_epochs/max_steps. Hence this PR achieves that. Also updated documentation and example-deployment.yaml for single node & multi node.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@Yash9060 Yash9060 self-assigned this Sep 12, 2024
@Yash9060 Yash9060 requested a review from a team as a code owner September 12, 2024 17:56
@Yash9060 Yash9060 requested review from awonak, MattIrv and jdnurme and removed request for awonak September 12, 2024 17:56
demo/lightning/checkpoint/multinode/README.md Outdated Show resolved Hide resolved
@Yash9060 Yash9060 enabled auto-merge (squash) September 13, 2024 19:10
@Yash9060 Yash9060 merged commit ba13ae4 into main Sep 13, 2024
2 checks passed
@Yash9060 Yash9060 deleted the yashsha-params branch September 13, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants