Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the simple walkthrough Colab #11

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Add the simple walkthrough Colab #11

merged 4 commits into from
Mar 6, 2024

Conversation

bernardhan33
Copy link
Collaborator

@bernardhan33 bernardhan33 commented Mar 5, 2024 •
edited by jdnurme
Loading

I will follow up separately for

  1. adding the emphasis on the usage of data_format_fn.
  2. adding the section on demoing fast listing during dataset construction. I just managed to copy over a 2M dataset to the public bucket.
  • Tests pass
  • Appropriate changes to documentation are included in the PR

@bernardhan33 bernardhan33 self-assigned this Mar 5, 2024
@bernardhan33 bernardhan33 requested review from MattIrv and jdnurme March 5, 2024 21:46
jdnurme
jdnurme approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@jdnurme jdnurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on review conducted on Colab.

@bernardhan33 bernardhan33 merged commit 02c273d into GoogleCloudPlatform:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdnurme jdnurme jdnurme approved these changes

@MattIrv MattIrv Awaiting requested review from MattIrv

Assignees

@bernardhan33 bernardhan33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernardhan33 @jdnurme