Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single node async benchmark execution to integration tests #135

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

awonak
Copy link
Contributor

@awonak awonak commented Oct 2, 2024

This also refactors the flag for no-dataflux since that option is mutually exclusive with the other checkpoint save options.

Internal issue: b/369839708

  • Tests pass
  • Appropriate changes to documentation are included in the PR

This also refactors the flag for no-dataflux since that option is mutually exclusive with the other checkpoint save options.

Also adds single node async execution to integration tests.
@awonak awonak requested a review from a team as a code owner October 2, 2024 19:39
@awonak awonak requested review from MattIrv and jdnurme October 2, 2024 19:39
@awonak
Copy link
Contributor Author

awonak commented Oct 2, 2024

I spoke with @jdnurme about having a future follow-up PR to have the async benchmarks measuring end-to-end workloads instead of individual save_checkpoint calls here. This PR is still useful by having the new async checkpoint code executed in our integration tests, but to fully close out b/369839708, we would ideally like to have an end-to-end benchmark. This new benchmark test work is documented in b/371056459.

@awonak awonak merged commit b7d103d into main Oct 3, 2024
5 checks passed
@awonak awonak deleted the awonak-async-benchmark branch October 3, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants