Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor benchmark tables #136

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Refactor benchmark tables #136

merged 6 commits into from
Oct 3, 2024

Conversation

awonak
Copy link
Contributor

@awonak awonak commented Oct 2, 2024

Refactor benchmark tables to use Markdown instead of HTML for simple two dimensional pivot tables. This improves readability and maintainability.

awonak added 4 commits October 2, 2024 19:33
This also refactors the flag for no-dataflux since that option is mutually exclusive with the other checkpoint save options.

Also adds single node async execution to integration tests.
@awonak awonak requested a review from a team as a code owner October 2, 2024 22:26
@awonak awonak requested review from nep-mayur, abhibyreddi and jdnurme and removed request for a team October 2, 2024 22:26
Copy link
Collaborator

@MattIrv MattIrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this makes the code way easier to work with

Base automatically changed from awonak-async-benchmark to main October 3, 2024 16:50
@awonak awonak merged commit 2da15c1 into main Oct 3, 2024
5 checks passed
@awonak awonak deleted the awonak-markdown-edit branch October 3, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants