Update documented step time #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhibyreddi
requested review from
awonak,
bernardhan33,
MattIrv,
akansha1812 and
jdnurme
and removed request for
awonak and
bernardhan33
MattIrv
approved these changes
Oct 7, 2024
MattIrv
approved these changes
Oct 7, 2024
akansha1812
approved these changes
Oct 7, 2024
MattIrv
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running these benchmarks for fsspec, Matt observed that the per-step time was much higher than the documented time. I re-ran one of the benchmarks and confirmed that. For now, I'm updating the step time documented here. I will figure out what configured step time will lead to a per-step time of 1s, re-run the benchmarks and update the numbers.