-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-node checkpoint benchmark improvements #149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h into mirvine/distckpt
Yash9060
reviewed
Oct 15, 2024
Yash9060
approved these changes
Oct 15, 2024
abhibyreddi
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several minor fixes/improvements for the multi-node checkpoint benchmark:
Update the README with some missing instructions
Run as a module rather than directly with Python so that imports work correctly
Update
WORLD_SIZE
env var toNUM_NODES
because PyTorch / PyTorch Lightning appear to useWORLD_SIZE
for other purposesSet
use_orig_params=False
when creating the strategy, since this avoids the time-consuming step of flattening the optimizer state dictconfigure_optimizers
to useself.trainer.model.parameters
instead ofself.model.parameters
as in the default (see FSDP : The optimizer does not seem to reference any FSDP parameters. Lightning-AI/pytorch-lightning#17515)Make
NUM_DEVICES
a configurable environment variableAdd the ability to configure the strategy with AdamW or SGD optimizer. AdamW appears to result in larger checkpoint files that are about 20% of the GPU memory utilization
Tests pass
Appropriate changes to documentation are included in the PR