Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLAMA2 Simulated version #198

Merged
merged 12 commits into from
Nov 18, 2024
Merged

LLAMA2 Simulated version #198

merged 12 commits into from
Nov 18, 2024

Conversation

Yash9060
Copy link
Collaborator

@Yash9060 Yash9060 commented Nov 15, 2024

Fixes b/378909790
I have added a doc in the above issue which describes at how I calculated the correct size for each model.

There is lot of code duplication between multinode/simulated demo/benchmarks. I will raise a follow up PR to move all the code into common directory and re-use it everywhere.

I will also update documentation on how to run benchmark code in follow up PR.

Also removed certain piece of code from benchmark/simulated/benchmark.py which I accidentally checked in an earlier PR.

It's a good idea to open an issue first for discussion.

  • Tests pass

@Yash9060 Yash9060 self-assigned this Nov 15, 2024
@Yash9060 Yash9060 requested a review from a team as a code owner November 15, 2024 20:57
@Yash9060 Yash9060 requested a review from jdnurme November 15, 2024 21:20
Copy link
Contributor

@awonak awonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for the additional documentation and links to articles for context!

@Yash9060 Yash9060 merged commit 7b0ca9e into main Nov 18, 2024
5 checks passed
@Yash9060 Yash9060 deleted the sim-llama2 branch November 18, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants