Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boilerplate code for Dataflux-Pytorch Lightning demo #57

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

abhibyreddi
Copy link
Collaborator

No description provided.

@abhibyreddi abhibyreddi requested a review from a team as a code owner July 15, 2024 22:20
@abhibyreddi abhibyreddi requested review from jdnurme and divrawal July 15, 2024 22:20
@divrawal divrawal requested review from MattIrv and bernardhan33 and removed request for jdnurme and divrawal July 15, 2024 22:23
demo/lightning/data.py Outdated Show resolved Hide resolved
demo/lightning/data.py Outdated Show resolved Hide resolved
demo/lightning/train.py Outdated Show resolved Hide resolved
demo/lightning/data.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@abhibyreddi abhibyreddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the three new files from demo/lightning to demo/lightning/image-segmentation. Will probably have to move demo/image-segmentation to demo/pytorch/image-segmentation in a later PR.

I agree that the arguments to Unet3D and Unet3DDataModule constructors should be configurable. I will make that change after I have this workload up and running with hardcoded parameters.

@abhibyreddi abhibyreddi self-assigned this Jul 16, 2024
@abhibyreddi abhibyreddi enabled auto-merge (squash) July 16, 2024 00:46
@abhibyreddi abhibyreddi merged commit 9b877d5 into GoogleCloudPlatform:main Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants