Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Dataflux simple demo loops and add retry flags #59

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Refactor Dataflux simple demo loops and add retry flags #59

merged 6 commits into from
Jul 16, 2024

Conversation

MattIrv
Copy link
Collaborator

@MattIrv MattIrv commented Jul 16, 2024

A few things in this PR:

  • Add retry flags to the demo loop code now that it's configurable
  • Add a base-level Dockerfile to containerize the whole repo for testing on GKE
  • Restructure the demos and give them GKE deployment files, along with a README
  • Other minor fixes in the demo loops
  • Tests pass
  • Appropriate changes to documentation are included in the PR

@MattIrv MattIrv requested a review from a team as a code owner July 16, 2024 15:29
@MattIrv MattIrv force-pushed the mirvine/1kbenchmark branch from 3867f7b to b458316 Compare July 16, 2024 15:30
@MattIrv MattIrv merged commit fd94d8f into main Jul 16, 2024
2 checks passed
@MattIrv MattIrv deleted the mirvine/1kbenchmark branch July 16, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divrawal divrawal divrawal approved these changes

@abhibyreddi abhibyreddi abhibyreddi approved these changes

@jdnurme jdnurme Awaiting requested review from jdnurme

@bernardhan33 bernardhan33 Awaiting requested review from bernardhan33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattIrv @divrawal @abhibyreddi