Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse bucket name from ckpt directory name instead of separate parameter for bucket name #85

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

Yash9060
Copy link
Collaborator

@Yash9060 Yash9060 commented Aug 8, 2024

Internal Issue: b/352786281

Parse bucket_name from ckpt_dir_path instead of setting it separately. Updated Unit tests, benchmarks code, demos and documentation.

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@Yash9060 Yash9060 requested a review from a team as a code owner August 8, 2024 05:08
@Yash9060 Yash9060 requested review from divrawal, abhibyreddi and MattIrv and removed request for abhibyreddi August 8, 2024 05:08
@Yash9060 Yash9060 merged commit 6fa9631 into main Aug 8, 2024
2 checks passed
@Yash9060 Yash9060 deleted the gcsbucket branch August 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants