Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checkpointing support for the Dataflux Dataset.
From investigation it seems that we can confidently use blob.open() to create a file handler.
blob.open("rb")
will return aBlobReader
.blob.open("wb", ignore_flush=True)
will return aBlobWriter
.Both types implement
io.BufferedIOBase
so can be passed intotorch.save()
andtorch.load()
like demonstrated in the README.TODO: I haven't added unit tests to this yet -- I thought about writing mocks but decided to go with fakes. I wanted to share this PR first before making changes to
fake_gcs
so it would make more sense there. Will follow up on this next.