Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running demo code in listing-only mode #95

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Allow running demo code in listing-only mode #95

merged 5 commits into from
Aug 19, 2024

Conversation

abhibyreddi
Copy link
Collaborator

Training in skipped when --listing_only is passed to train.py and exits right after initializing the map style datasets.

  • Tests pass; ran locally and verified listing time is output when this flag is set
  • Appropriate changes to documentation are included in the PR

@abhibyreddi abhibyreddi requested a review from a team as a code owner August 19, 2024 20:09
@abhibyreddi abhibyreddi requested review from jdnurme, bernardhan33 and MattIrv and removed request for jdnurme August 19, 2024 20:09
MattIrv
MattIrv approved these changes Aug 19, 2024
View reviewed changes
demo/lightning/image-segmentation/README.md Outdated Show resolved Hide resolved
demo/lightning/image-segmentation/train.py Show resolved Hide resolved
@abhibyreddi abhibyreddi enabled auto-merge (squash) August 19, 2024 22:04
@abhibyreddi abhibyreddi merged commit 46fe57e into main Aug 19, 2024
2 checks passed
@abhibyreddi abhibyreddi deleted the image-seg-benchmark-listing-only branch August 19, 2024 22:10
Yash9060 pushed a commit that referenced this pull request Aug 24, 2024
@abhibyreddi @Yash9060
Allow running demo code in listing-only mode (#95)
2713918 
* Allow running demo code in listing-only mode

* Add a note about listing_only flag in README

* Add a note about passing both benhcark and listing_only flags

* Print listing time to stdout regardless of the mode

* Remove exit(0)
Yash9060 pushed a commit that referenced this pull request Aug 26, 2024
@abhibyreddi @Yash9060
Allow running demo code in listing-only mode (#95)
36e7547 
* Allow running demo code in listing-only mode

* Add a note about listing_only flag in README

* Add a note about passing both benhcark and listing_only flags

* Print listing time to stdout regardless of the mode

* Remove exit(0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIrv MattIrv MattIrv approved these changes

@bernardhan33 bernardhan33 Awaiting requested review from bernardhan33 bernardhan33 is a code owner automatically assigned from GoogleCloudPlatform/dataflux-python

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhibyreddi @MattIrv