Skip to content

Commit

Permalink
Revert "turn on the flag (#2889)" (#2892)
Browse files Browse the repository at this point in the history
This reverts commit 70735ea.
  • Loading branch information
Tulsishah authored Jan 13, 2025
1 parent e2ff2d0 commit 73773f8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cfg/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ func BuildFlagSet(flagSet *pflag.FlagSet) error {
return err
}

flagSet.BoolP("enable-atomic-rename-object", "", true, "Enables support for atomic rename object operation on HNS bucket.")
flagSet.BoolP("enable-atomic-rename-object", "", false, "Enables support for atomic rename object operation on HNS bucket.")

if err := flagSet.MarkHidden("enable-atomic-rename-object"); err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion cfg/params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
flag-name: "enable-atomic-rename-object"
type: "bool"
usage: "Enables support for atomic rename object operation on HNS bucket."
default: true
default: false
hide-flag: true

- config-path: "enable-hns"
Expand Down
4 changes: 2 additions & 2 deletions cmd/root_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -848,8 +848,8 @@ func TestArgsParsing_EnableAtomicRenameObjectFlag(t *testing.T) {
}{
{
name: "normal",
args: []string{"gcsfuse", "--enable-atomic-rename-object=false", "abc", "pqr"},
expectedEnableAtomicRenameObject: false,
args: []string{"gcsfuse", "--enable-atomic-rename-object=true", "abc", "pqr"},
expectedEnableAtomicRenameObject: true,
},
}

Expand Down

0 comments on commit 73773f8

Please sign in to comment.