-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacing gcs.Object with gcs.MinObject in gcs.Listing #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2657 +/- ##
==========================================
- Coverage 77.56% 77.44% -0.12%
==========================================
Files 109 110 +1
Lines 15576 15676 +100
==========================================
+ Hits 12081 12141 +60
- Misses 2979 3014 +35
- Partials 516 521 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vadlakondaswetha
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are fetching only MinObject attributes for reducing list API payload in this PR , creating a gcs.Object using the attributes fetched, converting this gcs.Object to gcs.MinObject , and ultimately , storing minObject in cache for serving listobject requests, the conversion from gcs.Object to gcs.MinObject is redundant.
Hence, in this PR, the gcs.Listing struct is modified to store gcs.MinObject instead of gcs.Object so that attributes fetched can be used to directly populate the minObject and stored in cache.
Link to the issue in case of a bug fix.
NA
Testing details