Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle gRPC precondition failures while creating object #2838

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

anushka567
Copy link
Member

@anushka567 anushka567 commented Dec 24, 2024

Description

This change addresses an issue identified in b/378625027 where gRPC precondition failures were not being handled correctly.

Previously, error handling only checked for HTTP status codes, but gRPC uses error code 9 for precondition failures. This update adds explicit handling for gRPC error code 9 to ensure proper detection and management of precondition failures in gRPC calls.

Additionally, gRPC tests are enabled for the rename_dir_limit test package to improve test coverage .

Note: Handling of rpc codes for the different flows will be taken seperately.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@anushka567 anushka567 added the execute-integration-tests Run only integration tests label Dec 24, 2024
@anushka567 anushka567 requested review from Tulsishah and a team as code owners December 24, 2024 11:02
@kislaykishore kislaykishore requested review from a team, BrennaEpp and gargnitingoogle and removed request for a team and BrennaEpp December 24, 2024 11:02
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.83%. Comparing base (9b80d44) to head (de68b9a).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/storage/bucket_handle.go 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
- Coverage   76.09%   75.83%   -0.26%     
==========================================
  Files         118      118              
  Lines       16224    16419     +195     
==========================================
+ Hits        12345    12451     +106     
- Misses       3358     3440      +82     
- Partials      521      528       +7     
Flag Coverage Δ
unittests 75.83% <60.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anushka567 anushka567 changed the title [Do not review] Fix: Handle gRPC precondition failures while creating object Fix: Handle gRPC precondition failures while creating object Dec 24, 2024
@anushka567 anushka567 merged commit 1732c7a into master Dec 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants