-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky parallel dirOps e2e tests #2852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2852 +/- ##
==========================================
+ Coverage 76.08% 76.10% +0.01%
==========================================
Files 118 118
Lines 16557 16557
==========================================
+ Hits 12598 12601 +3
+ Misses 3427 3425 -2
+ Partials 532 531 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tulsishah
changed the title
Fix flaky parallel dir ops test
Fix flaky parallel dir ops tests
Jan 2, 2025
kislaykishore
requested review from
a team,
BrennaEpp,
gargnitingoogle,
ashmeenkaur and
tritone
and removed request for
ashmeenkaur,
a team,
BrennaEpp,
gargnitingoogle and
tritone
January 2, 2025 10:10
kislaykishore
requested review from
gargnitingoogle and
a team
and removed request for
ashmeenkaur and
tritone
January 2, 2025 10:11
Tulsishah
changed the title
Fix flaky parallel dir ops tests
Fix flaky parallel dir ops e2e tests
Jan 2, 2025
Tulsishah
changed the title
Fix flaky parallel dir ops e2e tests
Fix flaky parallel dirops e2e tests
Jan 2, 2025
Tulsishah
changed the title
Fix flaky parallel dirops e2e tests
Fix flaky parallel dirOps e2e tests
Jan 2, 2025
ankitaluthra1
approved these changes
Jan 3, 2025
ashmeenkaur
pushed a commit
that referenced
this pull request
Jan 6, 2025
* fix flaky parellal dir ops test * remove unnecessary changes * remove unnecessary changes * fix rest of the tests * fix rest of the tests * small fix * fix rest of the tests * create common function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Potential Problems:
This can lead to a situation where lookUpErr == nil, but statInfo still appears nil in the main thread and cause panic.
Applied Fixes:
Link to the issue in case of a bug fix.
Testing details