Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming writes flush and sync flow #2856

Merged
merged 1 commit into from
Jan 6, 2025
Merged

streaming writes flush and sync flow #2856

merged 1 commit into from
Jan 6, 2025

Conversation

ashmeenkaur
Copy link
Collaborator

Description

This PR includes code changes to:

  • separate out flush and sync flow.
  • file inode test to test for both sync and flush.
  • integrate flush file and sync file for streaming writes and associated refactoring.

Link to the issue in case of a bug fix.

b/385064030

Testing details

  1. Manual - NA
  2. Unit tests - added
  3. Integration tests - NA

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.18%. Comparing base (94eddd0) to head (36372bc).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2856      +/-   ##
==========================================
+ Coverage   76.04%   76.18%   +0.13%     
==========================================
  Files         118      118              
  Lines       16557    16587      +30     
==========================================
+ Hits        12591    12636      +45     
+ Misses       3433     3421      -12     
+ Partials      533      530       -3     
Flag Coverage Δ
unittests 76.18% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashmeenkaur ashmeenkaur marked this pull request as ready for review January 6, 2025 05:57
@ashmeenkaur ashmeenkaur requested a review from a team as a code owner January 6, 2025 05:57
@kislaykishore kislaykishore requested a review from a team January 6, 2025 05:57
@ashmeenkaur ashmeenkaur requested review from vadlakondaswetha and removed request for a team and kislaykishore January 6, 2025 05:58
@kislaykishore kislaykishore requested review from a team and tritone and removed request for a team January 6, 2025 05:58
@ashmeenkaur ashmeenkaur merged commit edc5e7b into master Jan 6, 2025
19 checks passed
@ashmeenkaur ashmeenkaur deleted the sync-and-flush branch January 6, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants