Create global max blocks semaphore only once at file system level. #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2883 +/- ##
==========================================
+ Coverage 76.09% 76.17% +0.07%
==========================================
Files 118 118
Lines 16637 16640 +3
==========================================
+ Hits 12660 12675 +15
+ Misses 3443 3433 -10
+ Partials 534 532 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
requested review from
a team,
BrennaEpp and
tritone
and removed request for
a team and
BrennaEpp
vadlakondaswetha
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
global max blocks semaphore limits the total number of blocks used across the files when streaming writes are enabled. This config should be created only once at file system level and re-used across files.
Link to the issue in case of a bug fix.
b/388184725
Testing details