Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary comment about lock #2886

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Remove unnecessary comment about lock #2886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions internal/fs/fs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,8 +1379,6 @@ func (fs *fileSystem) symlinkInodeOrDie(

// invalidateChildFileCacheIfExist invalidates the file in read cache. This is used to
// invalidate the file in read cache after deletion of original file.
//
// LOCKS_REQUIRED(fs.mu)
func (fs *fileSystem) invalidateChildFileCacheIfExist(parentInode inode.DirInode, objectGCSName string) (err error) {
if fs.fileCacheHandler != nil {
if bucketOwnedDirInode, ok := parentInode.(inode.BucketOwnedDirInode); ok {
Expand Down Expand Up @@ -2053,7 +2051,6 @@ func (fs *fileSystem) Rename(
return fs.renameNonHierarchicalFile(ctx, oldParent, op.OldName, child.MinObject, newParent, op.NewName)
}

// LOCKS_EXCLUDED(fs.mu)
// LOCKS_EXCLUDED(oldParent)
// LOCKS_EXCLUDED(newParent)
func (fs *fileSystem) renameHierarchicalFile(ctx context.Context, oldParent inode.DirInode, oldName string, oldObject *gcs.MinObject, newParent inode.DirInode, newName string) error {
Expand Down Expand Up @@ -2081,7 +2078,6 @@ func (fs *fileSystem) renameHierarchicalFile(ctx context.Context, oldParent inod
return nil
}

// LOCKS_EXCLUDED(fs.mu)
// LOCKS_EXCLUDED(oldParent)
// LOCKS_EXCLUDED(newParent)
func (fs *fileSystem) renameNonHierarchicalFile(
Expand Down
Loading