Write Failure Improvements - Do not deviate from local file system when file is unlinked from the same mount #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
BrennaEpp,
tritone and
gargnitingoogle
and removed request for
a team,
BrennaEpp and
tritone
ashmeenkaur
reviewed
Jan 10, 2025
tools/integration_tests/stale_handle/stale_file_handle_local_file_test.go
Show resolved
Hide resolved
Co-authored-by: Ashmeen Kaur <[email protected]>
Co-authored-by: Ashmeen Kaur <[email protected]>
ashmeenkaur
reviewed
Jan 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2890 +/- ##
==========================================
- Coverage 76.14% 76.04% -0.10%
==========================================
Files 118 118
Lines 16640 16659 +19
==========================================
- Hits 12670 12669 -1
- Misses 3437 3450 +13
- Partials 533 540 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashmeenkaur
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes GCSFuse behavior to not throw any error for Sync and Flush of files that have been deleted from same mount.
Link to the issue in case of a bug fix.
Bug Link
Testing details