Refactor list_large_dir tests to use storage client to delete directories instead of gcloud. #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
BrennaEpp and
tritone
and removed request for
a team and
BrennaEpp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2905 +/- ##
==========================================
- Coverage 76.20% 76.03% -0.18%
==========================================
Files 118 119 +1
Lines 16637 16685 +48
==========================================
+ Hits 12679 12686 +7
- Misses 3426 3456 +30
- Partials 532 543 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tulsishah
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the list_large_dir tests to use the storage client for directory deletion instead of gcloud, addressing frequent test failures caused by issues with directory removal using gcloud. Additionally, it updates the tests to utilize testify/stretchr as part of our migration to these libraries. The PR also enhances the DeleteAllObjectsWithPrefix method to perform object deletions in parallel.
Link to the issue in case of a bug fix.
Bug Link
Testing details