Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially Revert "Disable tpc and emulator tests in e2e" #2926

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Jan 22, 2025

b/391057586 - Fix and put back TPC and emulator-tests

This partially reverts commit 9d33fa5.

This re-enables TPC e2e tests from the code. Instead of this, we'll disable TPC e2e tests from kokoro config which is more efficient.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

This partially reverts commit 9d33fa5.

This re-enables TPC e2e tests from the code. Instead of this, we'll
disable TPC e2e tests from kokoro config which is more efficient.
@gargnitingoogle gargnitingoogle marked this pull request as ready for review January 22, 2025 07:16
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners January 22, 2025 07:16
@kislaykishore kislaykishore requested review from a team, tritone and BrennaEpp and removed request for a team and tritone January 22, 2025 07:17
@gargnitingoogle gargnitingoogle added the execute-integration-tests Run only integration tests label Jan 22, 2025
@kislaykishore kislaykishore requested review from a team and tritone and removed request for BrennaEpp and a team January 22, 2025 07:17
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.66%. Comparing base (d45540f) to head (9ec8ee7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
+ Coverage   75.62%   75.66%   +0.03%     
==========================================
  Files         125      125              
  Lines       17641    17641              
==========================================
+ Hits        13341    13348       +7     
+ Misses       3738     3732       -6     
+ Partials      562      561       -1     
Flag Coverage Δ
unittests 75.66% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle merged commit cdadf09 into master Jan 22, 2025
22 checks passed
@gargnitingoogle gargnitingoogle deleted the gargnitin/reenable-tpc-e2e-tests branch January 22, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants