-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when the file name being statted is just "\n" #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2933 +/- ##
=======================================
Coverage 75.62% 75.63%
=======================================
Files 125 125
Lines 17641 17656 +15
=======================================
+ Hits 13341 13354 +13
Misses 3738 3738
- Partials 562 564 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
changed the title
Fix crash
Fix crash when the file name being statted is just "\n"
Jan 24, 2025
kislaykishore
requested review from
ankitaluthra1,
vadlakondaswetha,
a team,
BrennaEpp,
tritone and
gargnitingoogle
and removed request for
vadlakondaswetha,
a team,
BrennaEpp,
tritone and
gargnitingoogle
January 24, 2025 10:50
kislaykishore
requested review from
gargnitingoogle,
vadlakondaswetha and
BrennaEpp
and removed request for
vadlakondaswetha,
BrennaEpp and
gargnitingoogle
January 24, 2025 10:56
Tulsishah
reviewed
Jan 24, 2025
vadlakondaswetha
approved these changes
Jan 25, 2025
ashmeenkaur
pushed a commit
that referenced
this pull request
Jan 27, 2025
meet2mky
pushed a commit
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GCSFuse crashes when a stat call is made for a path where the file name is just "\n". Instead, return an ENOENT error.
Link to the issue in case of a bug fix.
b/391795883
GH Issue: #2939
Testing details