Add Symlink/ReadFile tests for streaming writes scenario and run CommonLocalFileTestSuite from Streaming writes package. #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2938 +/- ##
==========================================
- Coverage 75.48% 75.29% -0.19%
==========================================
Files 125 125
Lines 17664 17674 +10
==========================================
- Hits 13334 13308 -26
- Misses 3765 3805 +40
+ Partials 565 561 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
meet2mky
changed the title
meet2mky
added
streaming-writes
execute-integration-tests
kislaykishore
requested review from
a team,
gargnitingoogle,
BrennaEpp and
tritone
and removed request for
a team,
gargnitingoogle and
BrennaEpp
meet2mky
force-pushed
the
streaming-writes-it
branch
from
6789b15 to
3774469
Compare
meet2mky
force-pushed
the
streaming-writes-it
branch
from
3774469 to
03c7130
Compare
ashmeenkaur
reviewed
Jan 28, 2025
tools/integration_tests/streaming_writes/default_mount_local_file_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/streaming_writes/default_mount_local_file_test.go
Outdated
Show resolved
Hide resolved
ashmeenkaur
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding symlink file tests and read file tests for local file for streaming writes scenario. Only the tests which differ from the existing local file tests in local file package have been added here explicitly and all the common test are being run using CommonLocalFileTestSuite from streaming writes package. Added testify interface for better test suite setup.
Link to the issue in case of a bug fix.
b/388722649
Testing details