Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Readability fix] Be explicit that nil child is being returned. #2943

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

kislaykishore
Copy link
Collaborator

Description

Link to the issue in case of a bug fix.

b/391795883

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore added the execute-integration-tests Run only integration tests label Jan 27, 2025
@kislaykishore kislaykishore marked this pull request as ready for review January 27, 2025 08:25
@kislaykishore kislaykishore requested a review from a team as a code owner January 27, 2025 08:25
@kislaykishore kislaykishore requested review from charith87, a team, gargnitingoogle, BrennaEpp and tritone and removed request for charith87, a team, gargnitingoogle, BrennaEpp and tritone January 27, 2025 08:25
@kislaykishore kislaykishore requested a review from tritone January 27, 2025 08:27
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.22%. Comparing base (cce2741) to head (afffe99).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/fs/fs.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2943   +/-   ##
=======================================
  Coverage   75.22%   75.22%           
=======================================
  Files         125      125           
  Lines       17669    17670    +1     
=======================================
+ Hits        13292    13293    +1     
  Misses       3813     3813           
  Partials      564      564           
Flag Coverage Δ
unittests 75.22% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tulsishah
Tulsishah previously approved these changes Jan 27, 2025
@kislaykishore kislaykishore enabled auto-merge (squash) January 27, 2025 09:28
internal/fs/fs.go Outdated Show resolved Hide resolved
charith87
charith87 previously approved these changes Jan 29, 2025
@kislaykishore kislaykishore merged commit b2d4339 into master Jan 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants