Finalize object for any error in buffered writes flow #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmeenkaur
requested review from
ankitaluthra1 and
vadlakondaswetha
and removed request for
ankitaluthra1
kislaykishore
requested review from
a team,
gargnitingoogle,
BrennaEpp and
tritone
and removed request for
a team,
gargnitingoogle and
BrennaEpp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
+ Coverage 75.22% 75.29% +0.07%
==========================================
Files 125 125
Lines 17669 17668 -1
==========================================
+ Hits 13292 13304 +12
+ Misses 3813 3803 -10
+ Partials 564 561 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vadlakondaswetha
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were finalizing only for upload failure and out of order writes but it makes sense to finalize the object in case of any failure.
Link to the issue in case of a bug fix.
b/392834488
Testing details