Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doing flush for pending writes on rename file #2958

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

vadlakondaswetha
Copy link
Collaborator

Description

Doing this only when streaming writes is enabled to be safe. Will do it later for non-streaming writes.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@vadlakondaswetha vadlakondaswetha requested review from Tulsishah and a team as code owners January 31, 2025 08:52
@kislaykishore kislaykishore requested review from a team, gargnitingoogle, BrennaEpp and tritone and removed request for a team, gargnitingoogle and BrennaEpp January 31, 2025 08:52
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 37.83784% with 23 lines in your changes missing coverage. Please review.

Project coverage is 75.20%. Comparing base (45a8f47) to head (3b116fd).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/fs/fs.go 37.83% 22 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2958      +/-   ##
==========================================
- Coverage   75.28%   75.20%   -0.09%     
==========================================
  Files         125      125              
  Lines       17669    17734      +65     
==========================================
+ Hits        13302    13336      +34     
- Misses       3805     3833      +28     
- Partials      562      565       +3     
Flag Coverage Δ
unittests 75.20% <37.83%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vadlakondaswetha vadlakondaswetha added the execute-integration-tests Run only integration tests label Jan 31, 2025
@vadlakondaswetha vadlakondaswetha merged commit c1f9198 into master Feb 3, 2025
12 checks passed
@ashmeenkaur ashmeenkaur deleted the flushonrename branch February 3, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants