Fixing flushPendingWrites method #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
gargnitingoogle and
tritone
and removed request for
a team and
gargnitingoogle
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2975 +/- ##
==========================================
+ Coverage 75.22% 75.25% +0.03%
==========================================
Files 125 125
Lines 17735 17736 +1
==========================================
+ Hits 13341 13348 +7
+ Misses 3830 3821 -9
- Partials 564 567 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashmeenkaur
previously approved these changes
Feb 7, 2025
ashmeenkaur
approved these changes
Feb 7, 2025
ashmeenkaur
pushed a commit
that referenced
this pull request
Feb 7, 2025
* Fixing flushPendingWrites method * fixing struct name * Fixing move_file test * Not flushing pending writes for local file * running rename test for buffered writes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the minObject to be returned after flush.
Link to the issue in case of a bug fix.
NA
Testing details