fix: add a stub implementation of channelz in the channel pool to fix…

… compilation (#137) * fix: add a stub implementation of channelz in the channel pool to fix compilation * remove stale tests that tested pre-grpc-js behavior * use first channel for channelz * use type inference
GoogleCloudPlatform · Apr 5, 2022 · a05c3dd · a05c3dd
1 parent 0b3d830
commit a05c3dd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/src/gcp_channel_factory.ts b/src/gcp_channel_factory.ts
@@ -103,6 +103,10 @@ export function getGcpChannelFactoryClass(
       this.getChannelRef();
     }
 
+    getChannelzRef() {
+      return this.channelRefs[0].getChannel().getChannelzRef();
+    }
+
     private initMethodToAffinityMap(gcpApiConfig: ApiConfig): void {
       const methodList = gcpApiConfig.method;
       if (methodList) {

diff --git a/test/unit/channel_factory_test.js b/test/unit/channel_factory_test.js
@@ -90,16 +90,6 @@ for (const grpcLibName of ['grpc', '@grpc/grpc-js']) {
           assert.doesNotThrow(() => {
             new grpcGcp.GcpChannelFactory('hostname', insecureCreds, {key: 5});
           });
-          assert.throws(() => {
-            new grpcGcp.GcpChannelFactory('hostname', insecureCreds, {
-              key: null,
-            });
-          });
-          assert.throws(() => {
-            new grpcGcp.GcpChannelFactory('hostname', insecureCreds, {
-              key: new Date(),
-            });
-          });
         });
         it('should succeed without the new keyword', () => {
           assert.doesNotThrow(() => {