networkd(vlan): remove the interface in addition to config #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By only removing the configuration file and reloading it will not remove the actual interface, for that we need to ask networkd to actively remove the interface for us. In order to maintain consistency of what's presend on disk and the MDS representation + guest agent state we are forcing the removal of the interface first and then removing the config, in case of error during networkctl call we keep using the on disk state to determine what to remove/keep.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dorileo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By only removing the configuration file and reloading it will not remove the actual interface, for that we need to ask networkd to actively remove the interface for us.
In order to maintain consistency of what's presend on disk and the MDS representation + guest agent state we are forcing the removal of the interface first and then removing the config, in case of error during networkctl call we keep using the on disk state to determine what to remove/keep.