Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate entries for the metadata server in /etc/hosts #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rjschwei
Copy link

In cases where the metadata server /etc/hosts entry was not added by the guest environment scripts there will be no "# Added by Google" marker. As such the script will add a second reference to the metadata if it already exists. We should only have 1 entry. Respect the already existing entry and do not add a second entry.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rjschwei
Once this PR has been reviewed and has the lgtm label, please assign elicriffield for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from jjerger and zmarano December 13, 2024 21:26
Copy link

Hi @rjschwei. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zmarano zmarano requested review from a-crate and dorileo and removed request for jjerger December 14, 2024 22:26
@a-crate
Copy link
Contributor

a-crate commented Dec 16, 2024

FYI, it will probably be several weeks before this can be merged and released due to holiday code and release freezes.

In cases where the metadata server /etc/hosts entry was not added by the
guest environment scripts there will be no "# Added by Google" marker. As
such the script will add a second reference to the metadata if it already
exists. We should only have 1 entry. Respect the already existing entry and
do not add a second entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants