Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoint ready test is failing #60

Closed
jlewi opened this issue Jun 23, 2020 · 11 comments
Closed

endpoint ready test is failing #60

jlewi opened this issue Jun 23, 2020 · 11 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jun 23, 2020

https://k8s-testgrid.appspot.com/sig-big-data#kubeflow-gcp-blueprints-master-periodic

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.87

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
platform/gcp 0.88

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

1 similar comment
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
platform/gcp 0.88

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented Jun 23, 2020

The request URL is incorrect

INFO|01:29:17|/workspace/kfctl-repo/py/kubeflow/kfctl/testing/util/gcp_util.py|81| Trying url: https://.endpoints.kubeflow-ci-deployment.cloud.goog
INFO|01:29:17|/workspace/kfctl-repo/py/kubeflow/kfctl/testing/util/gcp_util.py|93| https://.endpoints.kubeflow-ci-deployment.cloud.goog: Endpoint not ready, exception caught encoding with 'idna' codec failed (UnicodeError: label empty or too long), request number: 1

The test is missing the actual endpoint name.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/kfctl 1.00

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented Jun 23, 2020

The problem is that we aren't setting app-name
https://github.com/kubeflow/kfctl/blob/21e797701e9363c4145c5eca088221a861f3ea5c/py/kubeflow/kfctl/testing/pytests/endpoint_ready_test.py#L23

We need get-credentials to spit out the name of the endpoint so we can use it in subsequent steps

@jlewi
Copy link
Contributor Author

jlewi commented Jun 23, 2020

Related issue: kubeflow/testing#701

@jlewi
Copy link
Contributor Author

jlewi commented Jun 30, 2020

get credentials is failing

{"level":"info","ts":1593545683.0309026,"logger":"fallback-logger","caller":"logging/config.go:69","msg":"Fetch GitHub commit ID from kodata failed: \"KO_DATA_PATH\" does not exist or is empty"}
/usr/lib/python3/dist-packages/Crypto/Random/Fortuna/FortunaGenerator.py:28: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if sys.version_info[0] is 2 and  sys.version_info[1] is 1:
/usr/lib/python3/dist-packages/Crypto/Random/Fortuna/FortunaGenerator.py:28: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if sys.version_info[0] is 2 and  sys.version_info[1] is 1:
usage: get_kf_testing_cluster.py [-h] [--project PROJECT]
                                 [--base_name BASE_NAME]
                                 [--testing_cluster_label TESTING_CLUSTER_LABEL]
                                 [--field {all,endpoint,zone,name}]
                                 [--location LOCATION]
                                 [--find_latest_deployed]
                                 [--find_oldest_deployed]
                                 {list,get,get-credentials} ...
get_kf_testing_cluster.py: error: unrecognized arguments: --base=kf-vbp-.* --location=us-central1 --output=/workspace/cluster.info.yaml

@jlewi
Copy link
Contributor Author

jlewi commented Jun 30, 2020

Is the code in the docker image outdated?
gcr.io/kubeflow-ci/test-worker-py3@sha256:4a766d6f5cc6cbcb00dbc96205f7a5b2816bc5f2b6d516fd67124d4a3e6508ea

@jlewi
Copy link
Contributor Author

jlewi commented Jun 30, 2020

confirmed image is outdated
gcr.io/kubeflow-ci/test-worker-py3@sha256:4a766d6f5cc6cbcb00dbc96205f7a5b2816bc5f2b6d516fd67124d4a3e6508ea

jlewi pushed a commit to jlewi/testing that referenced this issue Jun 30, 2020
* Related to GoogleCloudPlatform/kubeflow-distribution#60 previous image was missing
  latest get-credentials code.
k8s-ci-robot pushed a commit to kubeflow/testing that referenced this issue Jun 30, 2020
* Related to GoogleCloudPlatform/kubeflow-distribution#60 previous image was missing
  latest get-credentials code.
@jlewi jlewi closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant