-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added monitoring metrics scope and monitored project resources. #5218
Added monitoring metrics scope and monitored project resources. #5218
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
6535714
to
94f6667
Compare
okay, let's kick off those tests. /gcbrun |
/gcbrun |
/gcbrun |
1 similar comment
/gcbrun |
Okay, both https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstreamVcr/206713? and https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstreamVcr/206715 are triggered for this - if either of them is able to start running, we'll get that test run. |
Co-authored-by: Scott Suarez <[email protected]>
Hmm- the product name in the website is off, but that's not unique to this change so it shouldn't block. Filed hashicorp/terraform-provider-google#10123. fyi @slevenick |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccMonitoringMetricsScope_BasicMetricsScope|TestAccMonitoringMonitoredProject_BasicMonitoredProject|TestAccOrgPolicyPolicy_EnforcePolicy|TestAccOrgPolicyPolicy_FolderPolicy|TestAccOrgPolicyPolicy_OrganizationPolicy|TestAccOrgPolicyPolicy_ProjectPolicy You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=206742 |
Going to check that test for a flake. |
/gcbrun |
* Added monitoring metrics scope and monitored project resources. * Ran make upgrade-dcl * Fixed indentation * Copied tpgtools go.sum lines into mmv1 go.sum. * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Attempted to fix strange downstream change in iam.go. * Added missing custom serializer to GA version, upgraded DCL again. * Update ID format so import is possible. Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Nathan Mckinley <[email protected]>
* Added monitoring metrics scope and monitored project resources. * Ran make upgrade-dcl * Fixed indentation * Copied tpgtools go.sum lines into mmv1 go.sum. * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Attempted to fix strange downstream change in iam.go. * Added missing custom serializer to GA version, upgraded DCL again. * Update ID format so import is possible. Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Nathan Mckinley <[email protected]>
…5235) * Added monitoring metrics scope and monitored project resources. (#5218) * Added monitoring metrics scope and monitored project resources. * Ran make upgrade-dcl * Fixed indentation * Copied tpgtools go.sum lines into mmv1 go.sum. * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Attempted to fix strange downstream change in iam.go. * Added missing custom serializer to GA version, upgraded DCL again. * Update ID format so import is possible. Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Nathan Mckinley <[email protected]> * Revert reversion of metrics scopes * Remove scope from provider. * Remove from GA, remove metrics scope from provider. * Added missing strings import for mmv1 dataproc cluster test. * Ran make serialize. * Removed unneeded overrides. Re-ran make serialize. * Removed undeletable override. Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Scott Suarez <[email protected]>
…s. (GoogleCloudPlatform#5218)" (GoogleCloudPlatform#5229) This reverts commit 243d91e.
…leCloudPlatform#5218) * Added monitoring metrics scope and monitored project resources. * Ran make upgrade-dcl * Fixed indentation * Copied tpgtools go.sum lines into mmv1 go.sum. * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Attempted to fix strange downstream change in iam.go. * Added missing custom serializer to GA version, upgraded DCL again. * Update ID format so import is possible. Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Nathan Mckinley <[email protected]>
…s. (GoogleCloudPlatform#5218)" (GoogleCloudPlatform#5229) This reverts commit 243d91e.
…oogleCloudPlatform#5235) * Added monitoring metrics scope and monitored project resources. (GoogleCloudPlatform#5218) * Added monitoring metrics scope and monitored project resources. * Ran make upgrade-dcl * Fixed indentation * Copied tpgtools go.sum lines into mmv1 go.sum. * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Attempted to fix strange downstream change in iam.go. * Added missing custom serializer to GA version, upgraded DCL again. * Update ID format so import is possible. Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Nathan Mckinley <[email protected]> * Revert reversion of metrics scopes * Remove scope from provider. * Remove from GA, remove metrics scope from provider. * Added missing strings import for mmv1 dataproc cluster test. * Ran make serialize. * Removed unneeded overrides. Re-ran make serialize. * Removed undeletable override. Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Scott Suarez <[email protected]>
fixes hashicorp/terraform-provider-google#10113
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)