Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

only allow one Metacontroller instance to be active at a time #66

Merged
merged 4 commits into from
Jul 23, 2018
Merged

only allow one Metacontroller instance to be active at a time #66

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e9ba07
only allow one Metacontroller instance be active at a time
crimsonfaith91 Jul 17, 2018
93fa064
use apps/v1beta2 StatefulSet
crimsonfaith91 Jul 17, 2018
a42a6c7
changed and passed example smoke tests
crimsonfaith91 Jul 19, 2018
8922193
remove redundant specification of service name
crimsonfaith91 Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/_guide/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Replace `<user>` and `<domain>` above based on the account you use to authentica
```sh
# Create 'metacontroller' namespace, service account, and role/binding.
kubectl apply -f {{ site.repo_raw }}/manifests/metacontroller-rbac.yaml
# Create CRDs for Metacontroller APIs, and the Metacontroller Deployment.
# Create CRDs for Metacontroller APIs, and the Metacontroller StatefulSet.
kubectl apply -f {{ site.repo_raw }}/manifests/metacontroller.yaml
```

Expand All @@ -39,7 +39,7 @@ If you prefer to build and host your own images, please see the
## Configuration

The Metacontroller server has a few settings that can be configured
with command-line flags (by editing the Metacontroller Deployment
with command-line flags (by editing the Metacontroller StatefulSet
in `manifests/metacontroller.yaml`):

| Flag | Description |
Expand Down
4 changes: 2 additions & 2 deletions manifests/dev/args.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Override args for development mode.
apiVersion: apps/v1beta1
kind: Deployment
apiVersion: apps/v1
kind: StatefulSet
metadata:
name: metacontroller
namespace: metacontroller
Expand Down
4 changes: 2 additions & 2 deletions manifests/dev/image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Override image for development mode (skaffold fills in the tag).
apiVersion: apps/v1beta1
kind: Deployment
apiVersion: apps/v1
kind: StatefulSet
metadata:
name: metacontroller
namespace: metacontroller
Expand Down
4 changes: 2 additions & 2 deletions manifests/metacontroller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ spec:
singular: controllerrevision
kind: ControllerRevision
---
apiVersion: apps/v1beta1
kind: Deployment
apiVersion: apps/v1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use apps/v1beta2 for now so we maintain compatibility with k8s 1.8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted!

Copy link
Contributor Author

@crimsonfaith91 crimsonfaith91 Jul 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enisoc When should we change the version from apps/v1beta2 to apps/v1? When the v1.8 is not supported anymore?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep support for 1.8 until we have a compelling use case for relying on a feature that only exists in 1.9+.

kind: StatefulSet
metadata:
name: metacontroller
namespace: metacontroller
Expand Down